mempool: Remove old fix sequence lock rejection. #2496
Conversation
davecgh
force-pushed
the
mempool_remove_old_fixseqlock_rejection
branch
from
8660996
to
0ae336b
Compare
There really can't be a concrete process because it largely depends on whatever the change(s) is/are doing and side effects, etc. In this particular case, the sequence locks that should have been valid were not being considered as such and thus any attempt to include them in a block template led to that block template being invalid. Since that is no longer the case and everybody must have updated now due to the associated hard fork vote, it can be removed from mempool now. If, on the other hand, the issue would've been that they were being calculated incorrectly and were valid when they shouldn't have been, this change wouldn't be possible in the same way. |
|
Gotcha, thanks. |
This updates the sequence lock mempool tests to be more consistent with the rest of the code in preparation for removing the old fix sequence locks rejection code.
This reworks the sequence lock acceptance tests to test for the explicit reason for a failure to ensure that each test is actually testing the intended condition.
This removes code that was introduced to reject sequence locks from the mempool until the fix sequence lock agenda became active since that agenda is now active and buried deep in the chain and thus there is no longer any reason check for it.
davecgh
force-pushed
the
mempool_remove_old_fixseqlock_rejection
branch
from
0ae336b
to
59c7f58
Compare
This removes code that was introduced to reject sequence locks from the mempool until the fix sequence lock agenda became active since that agenda is now active and buried deep in the chain and thus there is no longer any reason check for it.
It also reworks the sequence lock acceptance tests to test for the explicit reason for a failure to ensure that each test is actually testing the intended condition and to be more consistent with the rest of the code in preparation for removing the old fix sequence locks rejection code..
It is split into several commits to separate the test reformatting from the actual logic changes to ease review.