progresslog: Make block progress log internal. #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 10, 2020
dnldd
approved these changes
Dec 11, 2020
matheusd
approved these changes
Dec 14, 2020
This splits the block progress logging used by the block manager and dump blockchain option to a separate internal package named progresslog and updates its code to be more consistent with the rest of the code base along the way. This is a part of the overall effort to decouple the block manager from the server so it can be split out into a separate internal netsync package.
davecgh
force-pushed
the
progresslog_internal_package
branch
from
6a1cd67
to
7a80939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased on #2497.
This splits the block progress logging used by the block manager and dump blockchain option to a separate internal package named
progresslogand updates its code to be more consistent with the rest of the code base along the way.This is a part of the overall effort to decouple the block manager from the server so it can be split out into a separate internal
netsyncpackage.This is work towards #1145.