netsync/server: Update peer heights directly. #2542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
netsync_direct_peer_height_updates
branch
2 times, most recently
from
3fef472
to
167bfa3
Compare
dnldd
approved these changes
Jan 6, 2021
matheusd
approved these changes
Jan 7, 2021
rstaudt2
approved these changes
Jan 7, 2021
Now that the sync manager is aware of all peers, this modifies it to update their heights upon seeing the relevant announced blocks directly instead of threading back through the server via a callback that required a goroutine to avoid the otherwise circular lock.
davecgh
force-pushed
the
netsync_direct_peer_height_updates
branch
from
167bfa3
to
61d1065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #2541.
Now that the sync manager is aware of all peers, this modifies it to update their heights upon seeing the relevant announced blocks directly instead of threading back through the server via a callback that required a goroutine to avoid the otherwise circular lock.