Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Remove several unused funcs. #2561

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Jan 20, 2021

This removes several functions that are no longer used as they are defined directly on the RPC adapator for the rpcserver.ConnManager interface instead.

@davecgh davecgh added this to the 1.7.0 milestone Jan 20, 2021
@dnldd
Copy link
Member

dnldd commented Jan 20, 2021

How about removing ConnectedCount as well by moving its innards over to rpcConnManager.ConnectedCount ?

@davecgh
Copy link
Member Author

davecgh commented Jan 20, 2021

How about removing ConnectedCount as well by moving its innards over to rpcConnManager.ConnectedCount ?

Sounds fine to me. Mind taking care of that in a separate PR?

@dnldd
Copy link
Member

dnldd commented Jan 20, 2021

Just noticed server.ConnectedCount is used initializing the cpu miner, its passed to cpuminer.Config. Better off maintaining it to use at both sites than passing an anonymous func just for initializing the cpu miner. Disregard the suggestion.

This removes several functions that are no longer used as they are
defined directly on the RPC adapator for the rpcserver.ConnManager
interface instead.
@davecgh davecgh merged commit 7a2bebb into decred:master Jan 22, 2021
@davecgh davecgh deleted the server_remove_unused_funcs branch January 22, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants