Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: Update to siphash v1.2.2. #2577

Merged
merged 1 commit into from Jan 31, 2021

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Jan 29, 2021

This modifies the gcs and txscript modules to use the latest siphash v1.2.2.

While here, it also updates the main module to use the latest rpcclient.

@davecgh davecgh added this to the 1.7.0 milestone Jan 29, 2021
@davecgh davecgh force-pushed the multi_use_siphash_1_2_2 branch 2 times, most recently from 854b517 to 4fbd497 Compare January 29, 2021 23:50
This modifies the gcs and txscript modules to use the latest siphash
v1.2.2.

While here, it also updates the main module to use the latest rpcclient.

- github.com/dchest/siphash@v1.2.2
- github.com/decred/dcrd/rpcclient/v7@v7.0.0-20210129214723-fc227a05904d
@davecgh davecgh merged commit 0a8c52a into decred:master Jan 31, 2021
@davecgh davecgh deleted the multi_use_siphash_1_2_2 branch January 31, 2021 00:42
@ghost
Copy link

ghost commented Jan 31, 2021

Don't know if it's related, starting a new dcrd from branch multi_use_siphash_1_2_2 on rpi4 (ARMv7) with go1.15.7.linux-armv6l.tar.gz (I hope v6 was the right version to use) synced the chain fully, but shows this in the logs for each inbound connection.

2021-01-31 18:15:58.611 [WRN] SYNC: Attempt to lookup unknown peer 78.47.33.192:43014 (inbound)
Stake: goroutine 58 [running]:
runtime/debug.Stack(0x614230, 0x4be6840, 0x2e84a00)
	/home/dev/MAGIC/go/src/runtime/debug/stack.go:24 +0x78
github.com/decred/dcrd/internal/netsync.lookupPeer(0x2e84a00, 0x4be6840, 0x3)
	/home/dev/dcrd/internal/netsync/manager.go:296 +0x44
github.com/decred/dcrd/internal/netsync.(*SyncManager).handleDonePeerMsg(0x2c18240, 0x2e84a00)
	/home/dev/dcrd/internal/netsync/manager.go:577 +0x2c
github.com/decred/dcrd/internal/netsync.(*SyncManager).eventHandler(0x2c18240, 0x8e0970, 0x4be6d60)
	/home/dev/dcrd/internal/netsync/manager.go:1409 +0x7a0
created by github.com/decred/dcrd/internal/netsync.(*SyncManager).Run
	/home/dev/dcrd/internal/netsync/manager.go:1762 +0xa0

@davecgh
Copy link
Member Author

davecgh commented Feb 1, 2021

Thanks for the report on that. I'm going to open it up as a separate issue since it's not related to the siphash update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants