netsync: Use an APBF for recently rejected txns. #2590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
reviewed
Feb 12, 2021
davecgh
force-pushed
the
netsync_recently_rejected_txns_abpf
branch
from
0b9be86
to
248d46b
Compare
davecgh
commented
Feb 13, 2021
davecgh
force-pushed
the
netsync_recently_rejected_txns_abpf
branch
from
248d46b
to
f383032
Compare
This modifies the net sync manager to track the recently rejected transactions using a much more efficient APBF instead of map which needs store the entirety of the key for the items added to it. It also significantly increases the number of tracked rejected transactions thereby further lowering bandwidth usage in high rejection scenarios while simultaneously increasing robustness against malicious peers. More concretely, tracking the new higher number with the current map would take around 4.47 MiB per profiling while the new APBF only takes around 568 KiB, a reduction of around 88%, while exhibiting roughly the same computational performance.
davecgh
force-pushed
the
netsync_recently_rejected_txns_abpf
branch
from
f383032
to
48bf365
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the net sync manager to track the recently rejected transactions using a much more efficient APBF instead of map which needs store the entirety of the key for the items added to it.
It also significantly increases the number of tracked rejected transactions thereby further lowering bandwidth usage in high rejection scenarios while simultaneously increasing robustness against malicious peers.
More concretely, tracking the new higher number with the current map would take around 4.47 MiB per profiling while the new APBF only takes around 568 KiB, a reduction of around 88%, while exhibiting roughly the same computational performance.