Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addrmgr: Start v2 module dev cycle. #2592

Merged
merged 1 commit into from Feb 12, 2021

Conversation

sefbkn
Copy link
Member

@sefbkn sefbkn commented Feb 12, 2021

Upcoming changes constitute breaking public API changes to the addrmgr module. This PR follows the process for introducing major API breaks which consists of:

  • Bump the major version in the go.mod of the affected module if not already done since the last release tag
  • Add a replacement to the go.mod in the main module if not already done since the last release tag
  • Update all imports in the repo to use the new major version as necessary
  • Make necessary modifications to allow all other modules to use the new version in the same commit
  • Repeat the process for any other modules that require a new major as a result of consuming the new major(s)

Upcoming changes constitute breaking public API changes to the addrmgr
module, therefore, this follows the process for introducing major API
breaks which consists of:

- Bump the major version in the go.mod of the affected module if not
  already done since the last release tag
- Add a replacement to the go.mod in the main module if not already done
  since the last release tag
- Update all imports in the repo to use the new major version as
  necessary
- Make necessary modifications to allow all other modules to use the new
  version in the same commit
- Repeat the process for any other modules that require a new major as a
  result of consuming the new major(s)
@davecgh davecgh added this to the 1.7.0 milestone Feb 12, 2021
@davecgh davecgh merged commit 32a14f8 into decred:master Feb 12, 2021
@sefbkn sefbkn deleted the addrmgr_devel_introduce_v2 branch February 16, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants