rpctest: Make tests work properly with latest code. #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
added
the
test coverage
davecgh
force-pushed
the
rpctest_latest_code_fixes
branch
from
b539cdd
to
b0695ca
Compare
dnldd
approved these changes
Mar 11, 2021
rstaudt2
approved these changes
Mar 13, 2021
They were disabled a while ago because they took >20 minutes to run and CI (TravisCI) was timing out. It might not be the case anymore since we moved over to GitHub actions, so it might be worth reconsidering it now. However, if we do enable them, I'd like to see them modified to run much more quickly since waiting that long to see the results of the tests is not very desirable, imo. |
This corrects the tests in the rpctest package to work properly with the latest code. The tests were not failing by default because many of the tests in the rpctest package are not executed when only performing short tests which is the default mode used in run_tests.sh.
davecgh
force-pushed
the
rpctest_latest_code_fixes
branch
from
b0695ca
to
3aafa25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the tests in the
rpctestpackage to work properly with the latest code.The tests were not failing by default because many of the tests in the
rpctestpackage are not executed when only performing short tests which is the default mode used inrun_tests.sh.