dcrutil: Remove all code related to Address. #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
dcrutil_remove_address
branch
from
cc423a5
to
7fa6137
Compare
davecgh
force-pushed
the
dcrutil_remove_address
branch
from
7fa6137
to
1e287f0
Compare
davecgh
force-pushed
the
dcrutil_remove_address
branch
2 times, most recently
from
bb08ab8
to
eab478c
Compare
|
I've updated the |
This moves the AddressParams interface and associated mock implementations in the tests to util.go and util_address.go, respectively, in preparation for removing the Address type and related code.
This updates VerifyMessage to use the stdaddr package for addresses instead of the local Address type in preparation for its removal.
This removes all code related to defining and implementing the Address type since that is now handled by the stdaddr package.
davecgh
force-pushed
the
dcrutil_remove_address
branch
from
eab478c
to
1012d90
Compare
jrick
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #2626.
NOTE: I've left this marked as a draft for now because thego.modfile will need to be updated to use the latesttxscriptmodule once the aforementioned prerequisite PRs have landed to avoid issues for external consumers, however, this is otherwise ready for review.This updates
dcrutilto use the newstdaddrpackage instead of its localAddresstype and removes all code related to defining and implementing said type.It moves the
AddressParamsinterface and associated mock implementations in the tests toutil.goandutil_address.go, respectively, in a separate commit to prepare for the removal, then converts the remaining code that consumes theAddresstype to usestdaddrin a second commit, and finally removes all code related to defining and implementing theAddresstype in the final commit.