Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txscript: Split signing code to sign subpackage. #2642

Merged
merged 1 commit into from
May 7, 2021

Commits on May 7, 2021

  1. txscript: Split signing code to sign subpackage.

    The current code for handling signing standard scripts resides in
    txscript and depends on parsing and creating standard scripts.  This
    poses a problem for future work which intends to split the standard
    script handling from the consensus critical code since that code will
    also need to depend on txscript and therefore would result in a circular
    dependency.
    
    In order to pave the way for splitting the standard script handling
    without running into the aforementioned issue, this moves all of the
    signing code in the txscript package to a new subpackage named sign.
    
    As an aside, the signing code really never fit very well in the txscript
    package anyway and it only exists there because it was not possible to
    parse scripts outside of the package back when the original code was
    implemented.  However, that limitation no longer exists.
    
    It should also be noted that this only does the minimum work necessary
    to move the code and does not update it otherwise since future work
    plans to replace it with a much more robust architecture that properly
    handles things such as different script versions and non-standard
    scripts which the current code does not handle.
    davecgh committed May 7, 2021
    Configuration menu
    Copy the full SHA
    4e0be8d View commit details
    Browse the repository at this point in the history