-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpcserver: Set script version in raw tx results. #2663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
It looks like the API docs also need to be updated to include the version
field everywhere that scriptPubKey
is referenced (maybe you are planning on doing that separately since, given the discussion around this, it sounds like you'll also be deprecating the version
field at the output level).
Also, just a heads up, the PR title has a typo (rcpserver).
805cfc8
to
066a83f
Compare
@rstaudt2 Commit message updated. Yes, I was planning to do that as part of the PR to deprecate the |
I've added a commit to update the JSON-RPC API docs as well. |
I reviewed the API doc updates, and those look good to me as well. |
This ensures the recently-added script version field of types.ScriptPubKeyResult is set in the various RPCs that produce raw transaction results. Namely, getrawtransaction, decoderawtransaction, searchrawtransaction, and getblock (with the verbose tx flag set). Note that this is a duplicate of the types.Vout.Version field.
This updates the JSON-RPC API docs to include the version field as part of the scriptPubKey object for the RPCs that involve it.
77358f9
to
e279168
Compare
This ensures the recently-added script version field of
types.ScriptPubKeyResult
is set in the various RPCs that produce rawtransaction results. Namely,
getrawtransaction
,decoderawtransaction
,searchrawtransaction
, andgetblock
(with the verbose tx flag set).Note that this is a duplicate of the
types.Vout.Version
field.