rpcserver: Add more strict request origin check. #2676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
approved these changes
Jul 7, 2021
chappjc
reviewed
Jul 8, 2021
This makes the CORS policy for websocket clients more strict by ensuring any requests from other domains are rejected. It is worth noting that, in practice, the current less strict mechanism is secure due to both the use of a self-signed TLS certificate and the requirement for authentication to issue any commands, but further hardening is still desirable.
davecgh
force-pushed
the
rpcserver_strict_origin
branch
from
1f45655
to
e917dcb
Compare
dajohi
approved these changes
Jul 9, 2021
JoeGruffins
approved these changes
Jul 12, 2021
rstaudt2
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the CORS policy for websocket clients more strict by ensuring any requests from other domains are rejected. It is worth noting that, in practice, the current less strict mechanism is secure due to both the use of a self-signed TLS certificate and the requirement for authentication to issue any commands, but further hardening is still desirable.