rpcclient: Cancel client context on shutdown. #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeGruffins
approved these changes
Jul 14, 2021
dajohi
approved these changes
Jul 14, 2021
dnldd
approved these changes
Jul 15, 2021
This introduces a child context with cancellation to the manual Connect method and cancels it when the client is manually stopped via Shutdown to ensure callers are still able to shutdown the client via that method when using manual connections in addition to when using automatic ones.
davecgh
force-pushed
the
rpcclient_cancel_ctx_shutdown
branch
from
abe1f65
to
c9521b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a child context with cancellation to the manual
Connectmethod and cancels it when the client is manually stopped viaShutdownto ensure callers are still able to shutdown the client via that method when using manual connections in addition to when using automatic ones.