secp256k1: Use blake256 directly in examples. #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
approved these changes
Aug 4, 2021
rstaudt2
approved these changes
Aug 5, 2021
JoeGruffins
approved these changes
Aug 11, 2021
This modifies the ecdsa and schnorr examples to call blake256 directly instead of indirecting through chainhash in order to avoid the chainhash dependency which is otherwise not needed. The go.mod and go.sum files are updated accordingly to remove the no longer required dependency.
davecgh
force-pushed
the
secp256k1_no_chainhash_dep
branch
from
5a377e0
to
a1ce2e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the
ecdsaandschnorrexamples to callblake256directly instead of indirecting throughchainhashin order to avoid thechainhashdependency which is otherwise not needed.The
go.modandgo.sumfiles are updated accordingly to remove the no longer required dependency.