multi: Add FetchUtxoEntry to mining Config. #2709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
approved these changes
Aug 16, 2021
rstaudt2
force-pushed
the
mining-add-fetch-utxo-entry
branch
from
70602b3
to
7573e41
Compare
This adds a FetchUtxoEntry method to the mining Config. This allows the template generation logic to fetch unspent transaction outputs from the point of view of the main chain tip. This has not been necessary in the past since typically, the mining code uses FetchUtxoView to construct a viewpoint for transactions that it includes in a block template. However, with the automatic ticket revocations agenda, the template generation code will need to create new revocation transactions, which will require fetching utxos for the input tickets.
rstaudt2
force-pushed
the
mining-add-fetch-utxo-entry
branch
from
7573e41
to
1bcb1b0
Compare
JoeGruffins
approved these changes
Aug 26, 2021
davecgh
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
FetchUtxoEntrymethod to theminingConfig. This allows the template generation logic to fetch unspent transaction outputs from the point of view of the main chain tip. This has not been necessary in the past since typically, the mining code usesFetchUtxoViewto construct a viewpoint for transactions that it includes in a block template. However, with the automatic ticket revocations agenda, the template generation code will need to create new revocation transactions, which will require fetching utxos for the input tickets.