mempool: Accept test mungers for create tickets. #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
mempool_create_ticket_purchase_accept_mungers
branch
from
a9e90db
to
381e9e7
Compare
matheusd
approved these changes
Aug 30, 2021
rstaudt2
approved these changes
Aug 30, 2021
This modifies CreateTicketPurchase to accept a spendable output (instead of a transaction) as well as munge functions similar to how CreateSignedTx works and then introduces a new method named CreateTicketPurchaseFromTx which keeps the existing signature and is defined in terms of the aforementioned. This allows the test code to more easily mutate the transactions as desired prior to them being signed which provides greater flexibility.
davecgh
force-pushed
the
mempool_create_ticket_purchase_accept_mungers
branch
from
381e9e7
to
2086029
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies
CreateTicketPurchaseto accept a spendable output (instead of a transaction) as well as munge functions similar to howCreateSignedTxworks and then introduces a new method namedCreateTicketPurchaseFromTxwhich keeps the existing signature and is defined in terms of the aforementioned.This allows the test code to more easily mutate the transactions as desired prior to them being signed which provides greater flexibility.