dcrjson: Introduce v4 module. #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
approved these changes
Sep 6, 2021
rstaudt2
approved these changes
Sep 7, 2021
JoeGruffins
approved these changes
Sep 10, 2021
The current latest code for dcrjson already has breaking changes compared to the last release and was unfortunately not preceded by starting a new major version module per the standard process. Fortunately, the two modules in this repo that use dcrjson, namely rpcclient and rpc/json/rpctypes, use any of its types directly in their public API nor have any replacements to the code that contains the changes that require a new major version, so neither require a major version bump as a result. Therefore, this is able to mostly follow the process for introducing major API breaks as follows: - Bump the major version in the go.mod of the affected module if not already done since the last release tag - Add a replacement to the go.mod in the main module if not already done since the last release tag - Update all imports in the repo to use the new major version as necessary - Make necessary modifications to allow all other modules to use the new version in the same commit
davecgh
force-pushed
the
dcrjson_introduce_v4
branch
from
8497f89
to
99c8255
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current latest code for
dcrjsonalready has breaking changes compared to the last release and was unfortunately not preceded by starting a new major version module per the standard process.Fortunately, the two modules in this repo that use
dcrjson, namelyrpcclientandrpc/json/rpctypes, do not use any of its types directly in their public API nor have any replacements to the code that contains the changes that require a new major version, so neither require a major version bump as a result.Therefore, this is able to mostly follow the process for introducing major API breaks as follows:
go.modof the affected module if not already done since the last release tag