Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dcrctl: Clear terminal history #276

Merged
merged 1 commit into from Jul 8, 2016
Merged

dcrctl: Clear terminal history #276

merged 1 commit into from Jul 8, 2016

Conversation

alexlyp
Copy link
Member

@alexlyp alexlyp commented Jun 28, 2016 •
edited

Fixes #104

@alexlyp alexlyp changed the title [dcrctl] Clear terminal history dcrctl: Clear terminal history Jun 28, 2016
@raedah
Copy link
Contributor

raedah commented Jun 29, 2016 •
edited

I believe the above link should have linked to decred/dcrwallet#166

@alexlyp
Copy link
Member Author

alexlyp commented Jun 29, 2016

ah good call. fixing link

@raedah
Copy link
Contributor

raedah commented Jun 29, 2016

#104 propose a way of clearing the history in its entirety. This PR appears to achieve that.

decred/dcrwallet#166 proposes that passphrases are never saved in the --terminal history at all. I do not see that in this PR.

@alexlyp
Copy link
Member Author

alexlyp commented Jun 29, 2016 •
edited

I see. I'll remove decred/dcrwallet#166 from the commit message. I'll respond with more information concerning decred/dcrwallet#166 over there.

@jcvernaleo
Copy link
Member

This works as described so OK by me.

@alexlyp alexlyp merged commit 9146525 into decred:master Jul 8, 2016
@alexlyp alexlyp deleted the ayp_terminal_history branch July 8, 2016 16:09
@jcvernaleo jcvernaleo added this to the v0.2.0 milestone Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexlyp @raedah @jcvernaleo