multi: Use single latest checkpoint. #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
approved these changes
Oct 13, 2021
dnldd
reviewed
Oct 13, 2021
dnldd
reviewed
Oct 13, 2021
rstaudt2
force-pushed
the
blockchain-latest-checkpoint
branch
from
45bc071
to
4689c3c
Compare
dnldd
approved these changes
Oct 14, 2021
matheusd
reviewed
Oct 14, 2021
rstaudt2
force-pushed
the
blockchain-latest-checkpoint
branch
2 times, most recently
from
649dbeb
to
dc97a36
Compare
Good catch, thanks. Looks like that was accidentally committed when rebasing. Removed. |
rstaudt2
force-pushed
the
blockchain-latest-checkpoint
branch
2 times, most recently
from
a65d6ec
to
efc32f3
Compare
matheusd
approved these changes
Oct 15, 2021
This updates the blockchain checkpoints logic to use a single latest checkpoint rather than multiple checkpoints. The intermediate checkpoints are no longer necessary because headers first syncing was introduced, which discovers the most recent checkpoint before block syncing even starts.
rstaudt2
force-pushed
the
blockchain-latest-checkpoint
branch
from
efc32f3
to
79dbba9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on #2762.This updates the
blockchaincheckpoints logic to use a single latest checkpoint rather than multiple checkpoints. The intermediate checkpoints are no longer necessary because headers first syncing was introduced, which discovers the most recent checkpoint before block syncing even starts.