config: conditionally generate rpc credentials. #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the config to only generate random rpc credentials when the authorization type is basic.
davecgh
reviewed
Nov 3, 2021
JoeGruffins
approved these changes
Nov 4, 2021
There was a problem hiding this comment.
Working well for me.
I noticed the help in the created conf will say:
; Secure the RPC API by specifying the username and password. You must specify
; both or the RPC server will be disabled.
But really it can be enabled with the certificate file clients.pem as well. Or maybe it means if you specify one, both must be specified.
|
That needs to be updated in the sample config to indicate the options available, will sort it out. |
This updates the sample config documentation related to rpc credentials to indicate they are only needed if the authorization type is basic.
JoeGruffins
approved these changes
Nov 5, 2021
davecgh
approved these changes
Nov 5, 2021
rstaudt2
approved these changes
Nov 6, 2021
xaur
reviewed
Nov 29, 2021
| ; Secure the RPC API by specifying the username and password. You must specify | ||
| ; both or the RPC server will be disabled. | ||
| ; Secure the RPC API by specifying the username and password if the | ||
| ; authorization type is basic. You must specify both if so or the RPC |
There was a problem hiding this comment.
Looking at the reference to "basic" here, and how config.go handles client cert auth, I wonder if the sample config should mention params for auth type and clients.pem?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the config to only generate random rpc credentials when the authorization type is basic.
resolves #2739.