multi: Add bulk import mode. #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
approved these changes
Nov 6, 2021
This adds a bulk import mode that provides a mechanism to indicate that several validation checks can be avoided when bulk importing blocks already known to be valid. It will be used by the block importer in a subsequent commit. This provides an alternative mechanism to the current solution of passing a BehaviorFlags parameter around, which is inconvenient and makes it harder to determine where flags are being set.
This updates the block importer to enable bulk import mode on the chain rather than passing in the blockchain.BFFastAdd parameter when processing each block. This will allow the blockchain.BehaviorFlags parameter to be removed from the process block function in a subsequent commit.
rstaudt2
force-pushed
the
bulk-import-mode
branch
from
7b031b4
to
51b517a
Compare
dnldd
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a bulk import mode that provides a mechanism to indicate that several validation checks can be avoided when bulk importing blocks already known to be valid.
This provides an alternative mechanism to the current solution of passing a
BehaviorFlagsparameter around, which is inconvenient and makes it harder to determine where flags are being set.The second commit updates the block importer to enable bulk import mode on the chain rather than passing in the
blockchain.BFFastAddparameter when processing each block.