wire: Write message header directly. #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
approved these changes
Nov 8, 2021
rstaudt2
approved these changes
Nov 10, 2021
This modifies the message writing code that writes out message headers to write the fields directly instead of creating a copy of the data first. The primary motivation for this change is that the hdr.command field is assigned and never used in the existing code because the size-limited array variant of the command field is used instead when writing the elements. Since that field is unused, rather than creating a local partially-filled message header, and copying data into it only to turn around and write that data immediately, it makes more sense to just write the data directly.
davecgh
force-pushed
the
wire_unused_header_field
branch
from
1349f95
to
e430a7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the message writing code that writes out message headers to write the fields directly instead of creating a copy of the data first.
The primary motivation for this change is that the
hdr.commandfield is assigned and never used in the existing code because the size-limited array variant of the command field is used instead when writing the elements. Since that field is unused, rather than creating a local partially-filled message header, and copying data into it only to turn around and write that data immediately, it makes more sense to just write the data directly.