-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdscript: Add provably pruneable script support. #2803
stdscript: Add provably pruneable script support. #2803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few comment typos.
It looks like you addressed these in the PR that is on top of this. |
0e8e1d4
to
ce0480b
Compare
I meant to fix it in this PR, but looks like I fixed it later. I've put the fixes in the appropriate commit now. |
This adds an exported constant for the maximum allowed size of version 0 nulldata scripts to be considered standard and makes use of it instead of the one from txscript since the constant is eventually going to be removed from txscript given it is purely a standardness construct as opposed to a consensus rule.
This adds a function to generate a provably pruneable version 0 script that is considered standard since the equivalent variant of it is eventually going to be removed from txscript given it is a standardness construct as opposed to a consensus rule.
This updates README.md to describe provably pruneable scripts and document the new function.
ce0480b
to
f264e8c
Compare
This adds support for generating a provably pruneable version 0 script that is considered standard
stdscript
since the equivalent variant of it is eventually going to be removed fromtxscript
given it is a standardness construct as opposed to a consensus rule.It also adds an exported constant for the maximum allowed size of version 0 nulldata scripts to be considered standard and makes use of it instead of the one from
txscript
since it will also be removed fromtxscript
for the same reason.Finally, it updates
stdscript/README.md
to describe provably pruneable scripts and document the new function.