stdscript: Add provably pruneable script support. #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2021
rstaudt2
reviewed
Nov 16, 2021
It looks like you addressed these in the PR that is on top of this. |
rstaudt2
approved these changes
Nov 16, 2021
davecgh
force-pushed
the
stdscript_provably_pruneable_script
branch
from
0e8e1d4
to
ce0480b
Compare
I meant to fix it in this PR, but looks like I fixed it later. I've put the fixes in the appropriate commit now. |
matheusd
approved these changes
Nov 16, 2021
dnldd
approved these changes
Nov 16, 2021
This adds an exported constant for the maximum allowed size of version 0 nulldata scripts to be considered standard and makes use of it instead of the one from txscript since the constant is eventually going to be removed from txscript given it is purely a standardness construct as opposed to a consensus rule.
This adds a function to generate a provably pruneable version 0 script that is considered standard since the equivalent variant of it is eventually going to be removed from txscript given it is a standardness construct as opposed to a consensus rule.
This updates README.md to describe provably pruneable scripts and document the new function.
davecgh
force-pushed
the
stdscript_provably_pruneable_script
branch
from
ce0480b
to
f264e8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for generating a provably pruneable version 0 script that is considered standard
stdscriptsince the equivalent variant of it is eventually going to be removed fromtxscriptgiven it is a standardness construct as opposed to a consensus rule.It also adds an exported constant for the maximum allowed size of version 0 nulldata scripts to be considered standard and makes use of it instead of the one from
txscriptsince it will also be removed fromtxscriptfor the same reason.Finally, it updates
stdscript/README.mdto describe provably pruneable scripts and document the new function.