netsync: Request init state immediately upon sync. #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
netsync_immediate_initial_state
branch
from
545fb6c
to
a4c0a17
Compare
matheusd
approved these changes
Nov 16, 2021
davecgh
force-pushed
the
netsync_immediate_initial_state
branch
2 times, most recently
from
677ce12
to
1b214a1
Compare
dnldd
approved these changes
Nov 17, 2021
rstaudt2
approved these changes
Nov 17, 2021
davecgh
force-pushed
the
netsync_immediate_initial_state
branch
from
1b214a1
to
af40896
Compare
In an effort to consolidate the handling when the manager determines the initial chain sync process completes, this introduces a new method named onInitialChainSyncDone that is invoked accordingly and moves the duplicate log statement into the new method. This will also allow future commits to more easily add additional handling when the initial chain sync process completes.
This modifies the logic that requests the initial state to happen immediately when the initial chain sync process is complete as opposed to the existing approach that uses a separate goroutine with polling on a 3 second interval. This approach is more efficient since it avoids extra goroutines and also it also allows obtaining initial data, most notably pending treasury spend transaction and votes for the current best block, more quickly.
davecgh
force-pushed
the
netsync_immediate_initial_state
branch
from
af40896
to
19ffb98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the logic that requests the initial state to happen immediately when the initial chain sync process is complete as opposed to the existing approach that uses a separate goroutine with polling on a 3 second interval.
This approach is more efficient since it avoids extra goroutines and it also allows obtaining initial data, most notably pending treasury spend transactions and votes for the current best block, more quickly.