progresslog: Make header logging concurrent safe. #2833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstaudt2
approved these changes
Nov 23, 2021
This modifies the header progress logging function to be concurrent safe and modifies some comments to call out that the various functions are concurrent safe. This isn't strictly necessary with the current code because the function is only ever called from a single goroutine in the network sync manager, but the logger is intended to be concurrent safe and future code will likely make use of it from multiple goroutines.
davecgh
force-pushed
the
progresslog_concurrent_safe_header_log
branch
from
66952ab
to
6387f76
Compare
dnldd
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the header progress logging function to be concurrent safe and modifies some comments to call out that the various functions are concurrent safe.
This isn't strictly necessary with the current code because the function is only ever called from a single goroutine in the network sync manager, but the logger is intended to be concurrent safe and future code will likely make use of it from multiple goroutines.