Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: Allow discrete mining with invalidated tip. #2838

Merged

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Dec 3, 2021

This adds additional logic to the CPU miner's discrete mining process to detect when the block that it most recently submitted is no longer valid to prevent a hang in that case while still providing the desired behavior that waits for updated templates when invoked in rapid succession.

Fixes #2837.

@davecgh davecgh added this to the 1.7.0 milestone Dec 3, 2021
Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as intended. Just noted a small typo.

blockchain/chainquery.go Outdated Show resolved Hide resolved
This adds additional logic to the CPU miner's discrete mining process to
detect when the block that it most recently submitted is no longer valid
to prevent a hang in that case while still providing the desired
behavior that waits for updated templates when invoked in rapid
succession.
@davecgh davecgh force-pushed the multi_allow_discrete_mining_invalidated_tip branch from 1f77489 to c4564f1 Compare December 3, 2021 18:06
@davecgh davecgh merged commit c4564f1 into decred:master Dec 4, 2021
@davecgh davecgh deleted the multi_allow_discrete_mining_invalidated_tip branch December 4, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot generate simnet blocks after invalidating tip
3 participants