Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version: Include VCS build info in version string. #2841

Merged
merged 1 commit into from
Dec 17, 2021
Merged

version: Include VCS build info in version string. #2841

merged 1 commit into from
Dec 17, 2021

Conversation

jrick
Copy link
Member

@jrick jrick commented Dec 7, 2021 •
edited

VCS build info is only available when built from a VCS checkout using
Go 1.18 or later.

Example versions before and after this change:

$ go build && ./dcrd -V
dcrd version 1.7.0-pre (Go version go1.17.4 openbsd/amd64)
$ gotip build && ./dcrd -V
dcrd version 1.7.0-pre+3ab07abf1 (Go version devel go1.18-4300f1051 Tue Dec 7 18:58:57 2021 +0000 openbsd/amd64)

@matheusd matheusd mentioned this pull request Dec 15, 2021
Merged
@jrick
version: Include VCS build info in version string.
3f859cd 
VCS build info is only available when built from a VCS checkout using
Go 1.18 or later.
@davecgh davecgh added this to the 1.7.0 milestone Dec 17, 2021
@davecgh davecgh merged commit bdee08b into decred:master Dec 17, 2021
@jrick jrick deleted the vcscommitid branch December 17, 2021 20:25
@chappjc chappjc mentioned this pull request Mar 15, 2022
Closed
@ukane-philemon ukane-philemon mentioned this pull request Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnldd dnldd dnldd approved these changes

@davecgh davecgh davecgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrick @dnldd @davecgh