multi: Remove deprecated address index. #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
added
the
rpc server api change
davecgh
force-pushed
the
multi_remove_deprecated_addridx
branch
2 times, most recently
from
1aa3418
to
1894f42
Compare
dajohi
approved these changes
May 7, 2022
davecgh
force-pushed
the
multi_remove_deprecated_addridx
branch
from
1894f42
to
4a3c887
Compare
davecgh
force-pushed
the
multi_remove_deprecated_addridx
branch
2 times, most recently
from
b454be8
to
72cd571
Compare
This removes the deprecated searchrawtransactions method from the JSON-RPC API documentation. This is part of the overall removal of the deprecated address index.
This removes support for the deprecated searchrawtransactions method from the RPC client. This is part of the overall removal of the deprecated address index.
This removes the deprecated searchrawtransactions method from the RPC server along with associated tests and supporting code. This is part of the overall removal of the deprecated address index.
This removes the AddrIndexer interface and related test infrastructure since it is no longer used as of the removal of the address index code. This is part of the overall removal of the deprecated address index.
This removes the deprecated types for the searchrawtransactions method along with their tests. This is part of the overall removal of the deprecated address index.
This removes support for the address index which also entails removal of the --addrindex and --dropaddrindex flags as well as all related indexing infrastructure. The legacy index is now automatically dropped if it exists to ensure clients that are upgrading are not left with unneeded data in their databases. This is part of the overall removal of the deprecated address index.
This removes the deprecated getinfo method addrindex field from the JSON-RPC API documentation. This is part of the overall removal of the deprecated address index.
This removes the deprecated getinfo method addrindex field from the RPC server. This is part of the overall removal of the deprecated address index.
This removes the deprecated addrindex field from the getinforesult type. This is part of the overall removal of the deprecated address index.
davecgh
force-pushed
the
multi_remove_deprecated_addridx
branch
from
72cd571
to
af533c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the deprecated address index along with the associated CLI flags (
--addrindexand--dropaddrindex) andsearchrawtransactionsJSON-RPC that depends on it.The removals have been split into multiple commits to ease the review process and also ensure everything continues to work properly each step of the way.
The following is a high level overview of the changes:
searchrawtransactionsaddrindexfield ofgetinfosearchrawtransactionmethod from therpcclientsearchrawtransactionsaddrindexfield ofgetinforpc/jsonrpc/types:SearchRawTransactionsCmdSearchRawTransactionsResultInfoChainResult.AddrIndexblockchain/indexersandserver:--addrindexand--dropaddrindexCLI flagssampleconfigaccordingly