build: Enable run_tests.sh to work with go.work. #3021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script `run_tests.sh` does not work if a go.work file is present in the project root. This is because when a `go.work` file is present, `go list -m` returns the names of all modules in the workspace rather than just the parent module in the root directory. Removing the `-m` flag fixes this.
matheusd
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
I tested a bunch of things but couldn't break this when running run_tests.sh inside the dcrd repo.
Only way I could break go list using a workspace was by working on a different cwd and using a workspace with (for example) use ./dcrd, but I expect that's not an intended use case for run_tests.sh.
davecgh
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Thanks for the PR. This is indeed the case and can easily be seen by running versions of Go before and after the introduction of workspaces:
$ go1.16.15 list -m
github.com/decred/dcrd
$ go1.17.13 list -m
github.com/decred/dcrd
$ go1.18.8 list -m
github.com/decred/dcrd
github.com/decred/base58
github.com/decred/dcrd/addrmgr/v2
...
davecgh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script
run_tests.shdoes not work if a go.work file is present in the project root. This is because when ago.workfile is present,go list -mreturns the names of all modules in the workspace rather than just the parent module in the root directory. Removing the-mflag fixes this.