chaincfg: Enforce globally unique vote IDs. #3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
chaincfg_enforce_globally_unique_voteids
branch
from
4ca0c6b
to
74df71a
Compare
davecgh
force-pushed
the
chaincfg_enforce_globally_unique_voteids
branch
from
74df71a
to
0e11f17
Compare
The code currently supports reusing the same vote ID to refer to different agendas as long as they are in different agenda versions. While there is nothing technically incorrect about this, and part of the design is to allow it, various other software in the ecosystem implicitly assumes the IDs are globally unique across all agendas. Due to this, and also because supporting it makes the internal code more complex to deal with as well, there is currently a bit of an unwritten rule that the vote ID for every agenda across all versions should be unique. This change effectively formalizes that unwritten rule by modifying the validation logic that happens at initialization time to reject deployments that have duplicate IDs across agenda versions.
davecgh
force-pushed
the
chaincfg_enforce_globally_unique_voteids
branch
from
0e11f17
to
3d38b7b
Compare
dajohi
approved these changes
Feb 24, 2023
ukane-philemon
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #3056.The code currently supports reusing the same vote ID to refer to different agendas as long as they are in different agenda versions.
While there is nothing technically incorrect about this, and part of the design is to allow it, various other software in the ecosystem implicitly assumes the IDs are globally unique across all agendas.
Due to this, and also because supporting it makes the internal code more complex to deal with as well, there is currently a bit of an unwritten rule that the vote ID for every agenda across all versions should be unique.
This change effectively formalizes that unwritten rule by modifying the validation logic that happens at initialization time to reject deployments that have duplicate IDs across agenda versions.