Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpctests: Pass test loggers to dcrdtest package #3232

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

jrick
Copy link
Member

@jrick jrick commented Apr 4, 2024

This sets the dcrdtest package-level logger to a backend that writes logs to each test variable. It writes trace level logs as this was the only way to observe the node process' stdout and stderr.

@jrick jrick changed the title rpctest: Pass test loggers to dcrdtest package rpctests: Pass test loggers to dcrdtest package Apr 4, 2024
@jrick
Copy link
Member Author

jrick commented Apr 4, 2024

ah, this would need an update to dcrdtest as well for the UseLogger function. I had that update sitting locally in my tree for now.

@davecgh davecgh added this to the 1.9.0 milestone Apr 4, 2024
@davecgh davecgh added the test coverage Discussion and pull requests for improving test coverage. label Apr 4, 2024
This sets the dcrdtest package-level logger to a backend that writes logs to
each test variable.  It writes trace level logs as this was the only way to
observe the node process' stdout and stderr.
@davecgh davecgh merged commit 097c718 into decred:master Apr 4, 2024
2 checks passed
@jrick jrick deleted the rpctest_log branch April 8, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test coverage Discussion and pull requests for improving test coverage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants