mining: Update blk templ diff for too few voters. #3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
approved these changes
May 3, 2024
This updates the block template generation path for handling too few voters to also update the required difficulty bits in the created block template since the new ASERT difficulty algorithm changes every block and is influenced by the timestamp. This is necessary to prevent the possibility of generating block templates that fail to validate and have to be discarded resulting in unnecessary additional work while aggressive mining in the aforementioned case of not having enough voters.
davecgh
force-pushed
the
mining_update_diff_too_foo_voters
branch
from
912ce6a
to
8de792c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the block template generation path for handling too few voters to also update the required difficulty bits in the created block template since the new ASERT difficulty algorithm changes every block and is influenced by the timestamp.
This is necessary to prevent the possibility of generating block templates that fail to validate and have to be discarded resulting in unnecessary additional work while aggressive mining in the aforementioned case of not having enough voters.