Replace some unnecessary dcrutil.Tx usage with wire.MsgTx. #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
reviewed
Oct 12, 2016
| @@ -178,8 +178,9 @@ func (b *BlockChain) checkBlockContext(block *dcrutil.Block, prevNode *blockNode | |||
| func ticketsSpentInBlock(bl *dcrutil.Block) []chainhash.Hash { | |||
| var tickets []chainhash.Hash | |||
| for _, stx := range bl.STransactions() { | |||
There was a problem hiding this comment.
Perhaps change;
for _, stx := range bl.STransactions() {to
for _, mstx := range bl.MsgBlock().Sransactions {and drop
mstx := stx.MsgTx()
dajohi
reviewed
Oct 12, 2016
| @@ -191,8 +191,9 @@ func ticketsSpentInBlock(bl *dcrutil.Block) []chainhash.Hash { | |||
| func ticketsRevokedInBlock(bl *dcrutil.Block) []chainhash.Hash { | |||
| var tickets []chainhash.Hash | |||
| for _, stx := range bl.STransactions() { | |||
There was a problem hiding this comment.
for _, stx := range bl.MsgBlock().STransactions {
dajohi
reviewed
Oct 12, 2016
| @@ -1418,12 +1418,13 @@ func countSpentOutputs(block *dcrutil.Block, parent *dcrutil.Block) int { | |||
| } | |||
| } | |||
| for _, stx := range block.STransactions() { | |||
There was a problem hiding this comment.
for _, stx := range bl.MsgBlock().STransactions {
|
OK |
cjepson
approved these changes
Oct 12, 2016
| if txType == stake.TxTypeSSGen { | ||
| ticketH := stx.MsgTx().TxIn[1].PreviousOutPoint.Hash | ||
| ticketH := mstx.TxIn[1].PreviousOutPoint.Hash |
| @@ -659,8 +659,9 @@ func maybeInsertStakeTx(bm *blockManager, stx *dcrutil.Tx, treeValid bool) bool | |||
| "stx %s: %v", stx.Sha(), err) | |||
| return false | |||
| } | |||
| isSSGen, _ := stake.IsSSGen(stx) | |||
| for i, txIn := range stx.MsgTx().TxIn { | |||
| mstx := stx.MsgTx() | |||
There was a problem hiding this comment.
neither is better than the other. not worth changing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.