mempool: Optimize the votes map slices. #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This optimizes the vote map by making better use of Go's slice properties. In particular, instead of creating a slice with empty entries and iterating to find the next empty entry, just create the slice with a cap and append entries as needed. This allows the code simply take the len of the slice and range over it without needing additional code to deal with nil entries. While here, it also makes a few comments and returns more consistent with the rest of the code base.
|
OK tACK on tesnet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes the vote map by making better use of Go's slice properties. In particular, instead of creating a slice with empty entries and iterating to find the next empty entry, just create the slice with a cap
and append entries as needed. This allows the code simply take the
lenof the slice and range over it without needing additional code to deal with nil entries.While here, it also makes a few comments and returns more consistent with the rest of the code base.