Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one more consensus test #520

Merged
merged 1 commit into from
Jan 2, 2017
Merged

Add one more consensus test #520

merged 1 commit into from
Jan 2, 2017

Conversation

martelletto
Copy link
Contributor

@martelletto martelletto commented Dec 20, 2016

Ensure the rejection of blocks resulting in large serializations.

@davecgh
Copy link
Member

davecgh commented Dec 21, 2016

Looks like generate.go needs a gofmt per the failure on Travis.

@martelletto
Copy link
Contributor Author

Although I was unable to categorically prove it, evidence suggests that Travis' mysterious failures are due to a memory limit being hit. On my workstation, TestFullBlocks() takes about 11GB of memory. This is most likely due to 10^6 transactions being created to test ErrTooManyTransactions.

Ensure the rejection of blocks resulting in large serializations.
@martelletto martelletto changed the title Add two more consensus tests Add one more consensus test Dec 23, 2016
Copy link
Member

@alexlyp alexlyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, test appears to do what is described and handled properly

@martelletto martelletto merged commit f3e94e1 into decred:master Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants