wire: Lower MaxUserAgentLen to 256. #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The protocol was silently upgrade in Core some time ago to enforce a limit of 256 for the user agent in version messages. This updates wire to coincide with that change and consequently includes a wire version bump to 0.4.1.
davecgh
force-pushed
the
wire_lower_max_ua_len
branch
from
d6d7f70
to
3e4d74d
Compare
Upstream commit 763f731. This updates wire to enforce a limit of 256 instead of the existing 2000 to coincide with the upstream btcd project, and consequently includes a wire version bump to 0.2.1 in the merge commit.
davecgh
force-pushed
the
wire_lower_max_ua_len
branch
from
3e4d74d
to
83c65fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream commit 763f731.
This updates wire to enforce a limit of 256 instead of the existing 2000 to coincide with the upstream btcd project, and consequently includes a wire version bump to 0.2.1 in the merge commit.