Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mempool: Add test for max orphan entry eviction. #769

Merged
merged 2 commits into from
Jul 27, 2017

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Jul 27, 2017

Upstream commit e88f2d7.

The merge commit also contains the Decred-specific updates.


This adds a test to the mempool for ensuring that orphans are evicted when exceeding the max orphan policy setting as expected.

This adds a test to the mempool for ensuring that orphans are evicted
when exceeding the max orphan policy setting as expected.
@dajohi
Copy link
Member

dajohi commented Jul 27, 2017

travis says 'rpc_harness_test.go:262: mempools detected as synced yet harness has a new tx', but only on go 1.7... hmmm

@davecgh
Copy link
Member Author

davecgh commented Jul 27, 2017

That is just a false positive test failure. I've noticed it since the test went in. We'll need to hunt it down and fix the test. I restarted the Travis build.

Copy link
Member

@dajohi dajohi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Upstream commit e88f2d7.

The merge commit also contains the Decred-specific updates.
@davecgh davecgh force-pushed the merge_mempool_orphan_eviction_test branch from f2384db to 24f0724 Compare July 27, 2017 16:35
@davecgh davecgh merged commit 24f0724 into decred:master Jul 27, 2017
@davecgh davecgh deleted the merge_mempool_orphan_eviction_test branch July 27, 2017 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants