Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go version for example test run in readme #936

Merged
merged 1 commit into from Dec 4, 2017

Conversation

fgimenez
Copy link

@fgimenez fgimenez commented Dec 3, 2017

Hello! Following the readme I get an error with the suggested command for running the tests in a docker container with a previous version of Go, it happens to be 1.7, not the current previous one:

$ ./run_tests.sh 1.7
[...]
server.go:1282:11:warning: Until not declared by package time (gosimple)
server.go:1282:11:warning: Until not declared by package time (gosimple)
server.go:1282:11:warning: Until not declared by package time (unconvert)
server.go:1282:11:warning: Until not declared by package time (unconvert)
+ '[' 0 '!=' 0 ']'
+ go install . ./cmd/...
# github.com/decred/dcrd
./server.go:1282: undefined: time.Until

Not sure if this is intended, I've proposed changes for suggesting the previous, supported version of Go, in this case 1.8, which gives some warnings but doesn't fail.

Cheers!

Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davecgh davecgh merged commit cf45378 into decred:master Dec 4, 2017
@fgimenez fgimenez deleted the fix-test-go-version-readme branch December 14, 2017 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants