-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impossible to go back when visiting address page #814
Comments
Another related issue is that using the browser's <- and -> buttons to go through the different address pages #anchors is not possible. |
On dcrdata.org I never get forwarded to #list-view. I tested it in Chrome and Firefox. Is this a problem with the development version but not the live version? |
You'll need to try it on the dev version:
https://alpha.dcrdata.org/address/DsRZ8itu7XEkBNELzcJ4xKLapswhquKquUn
However, we are working out issues with the forward/back browser nav with
this, so it's not working properly anywhere yet.
…On Tue, Nov 27, 2018 at 2:19 PM ZeroASIC ***@***.***> wrote:
On dcrdata.org I never get forwarded to #list-view. I tested it in Chrome
and Firefox. Is this a problem with the development version but not the
live version?
https://explorer.dcrdata.org/tx/38a9c89aaa3445333c2ca1542c16d21ca33c946715a8e605e91f687df06e38e7
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#814 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AI8HSV6NBUPWMZk8XgGu1ySgJbLG_UlRks5uzZ42gaJpZM4Ya8Fb>
.
|
Yeah I noticed that on alpha. I looked at a little bit yesterday and I think I could probably fix this. Using the URL to contain information this way is the real culprit. It should be based on the state of the html elements. |
Great to hear. @buck54321 has a solution brewing too. Perhaps you can discuss it with him. |
Resolved by #870 |
When clicking an address from a transaction view, you are sent to the address page with no hash tag/#anchor, but the address page immediately redirects to #list-view, making a new browser history entry.
That is,
Going to http://127.0.0.1:7777/tx/38a9c89aaa3445333c2ca1542c16d21ca33c946715a8e605e91f687df06e38e7 and clicking the first output's address:
http://127.0.0.1:7777/address/DsRZ8itu7XEkBNELzcJ4xKLapswhquKquUn
then takes you to:
http://127.0.0.1:7777/address/DsRZ8itu7XEkBNELzcJ4xKLapswhquKquUn#list-view
Then if you click back, you cannot get to the /tx page because it takes you to the /address page, which immediately redirects to the #list-view address page.
The issue seems to be with:
Perhaps we should be using
replaceState
instead: https://developer.mozilla.org/en-US/docs/Web/API/History_API#The_replaceState()_methodThe text was updated successfully, but these errors were encountered: