Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explorer: market: add fiat and percent values to the market depth gap #1487

Merged
merged 1 commit into from
Jul 28, 2019

Conversation

buck54321
Copy link
Member

Resolves #1484

Modifies the depth chart gap display to show values in BTC, fiat, and percent, where percent is taken as (gapWidth/midGap*100).

image

Adds negative value support to humanize.threeSigFigs.

Modifies the depth chart gap display to show values in BTC, fiat,
and percent, where percent is taken as (gapWidth/midGap*100).

Adds negative value support to `humanize.threeSigFigs`.
Copy link
Member

@chappjc chappjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Seems to address #1484 nicely. @jzbz, look good?

@jzbz
Copy link
Member

jzbz commented Jul 28, 2019

Looks perfect.

@chappjc chappjc merged commit b224372 into decred:master Jul 28, 2019
@chappjc chappjc added this to the 5.1 milestone Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show bid/ask spread percentage
3 participants