explorer: update header and blocks pages #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
commented
Aug 9, 2019
|
Hi, in current layouts i use regular weight. For table headers use also regular and #596D81 |
chappjc
reviewed
Aug 15, 2019
views/extras.tmpl
Outdated
| <div class="col-sm-auto" style="padding: 0 2px"> | ||
| <a href="/" class="no-underline d-block home-link"> | ||
| <div class="dcrdata-logo"></div> | ||
| <header class="top-nav d-flex align-items-center" id="navBar" data-blocktime="{{.BlockTimeUnix}}"> |
There was a problem hiding this comment.
Tabs snuck in here. Just about all I noticed in a cursory review. Still testing though.
|
I think we should think about a different default page size. IMO the default should be able to fit on the screen without scrolling, especially since clicking next is easier than bouncing up and down in the window. 10-15 might be good. Here's 10:
|
|
Another thing that jumps out at me is the semi-transparent dashed line around the new logo. It was like that before, but for some reason it looks more prominent. Perhaps we can make the default item the first block in the table. |
chappjc
approved these changes
Aug 18, 2019
|
Should be good now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1191, decred/dcrdesign#139
Based on mockup by @harlovski: https://matrix.decred.org:8448/_matrix/media/r0/download/decred.org/PejFvrGLlVlpiRuZaHeBwChS
I'd like to use a font closer to the one in the mockup. @harlovski, can you tell me what font you used? Your font falls somewhere in-between my source-sans regular and semi-bold.
The mockup also used a slightly off-white for the header, where I'm still using white. The off-white looked okay on the blocks page, but not very good on others, Can try again later after more pages move towards this style.