performance optimizations and startup improvements #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid allocation and computing tx hash unless needed. Caller must check for nil result even with nil error. Check inputs before outputs. Skip output loop entirely if outputSpends map is empty.
Move the MsgTxAtomicSwapsInfo loop out of the transaction processing loop. All N txns were checked N times each!
This removes the unused RPC "blockgate" that became obsolete when dcrsqlite was removed. Polish the sync handling, removing ensureSync and moving the legacy project fund responsibility to main instead of SyncChainDB. Add PiProposalsHistory guard to prevent repeated calls from starting redundant concurrent queries. This is needed because the initial Pi updates started in main are async, plus the regular updates are on a timer and they need to know if a previous update is still running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a number of performance optimizations and startup improvements:
TxHashandBlockHash, usingCachedTxHashwhen it is a thread-safe location.txhelpers.MsgTxAtomicSwapsInfo: Avoid allocation and computing tx hash unless needed.Caller must check for nil result even with nil error. Check inputs before outputs. Skip output loop entirely if
outputSpendsmap is empty.MsgTxAtomicSwapsInfoin separate loop. Move theMsgTxAtomicSwapsInfoloop out of the transactionprocessing loop. All N txns were checked N times each!
getrawtransactionin(*StakeDatabase).applyDiffdcrsqlite was removed. Polish the sync handling, removing
ensureSyncand moving the legacyproject fund responsibility to main instead of
SyncChainDB.Stage 1: