New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: Upgrade to stimulus 3.0 #1890
Conversation
I will get you a proper review soon, but one thing I noticed is the new Data Mappings https://onrails.blog/2020/12/04/updating-to-stimulus-js-2-0/ so changing
to
you then change Any value to doing that? I can't tell if the old |
Hey mate @chappjc please take your time, no rush at all to review this 👍 Upon reading more on the new data value mapping API, we should definitely update this as well, since it provides some cool additional features.
Besides the out of the box type conversions and properties, imo it adds documentation value to the controller, since we can check the types being handled on a glance, while being a cleaner syntax. I think they will not drop support for the old API, but we should also update this to reap the improvements benefits and be up-to-date with the package. I'll get to it and commit these changes 👍 Reference: hotwired/stimulus#202 |
On a related note, I'd really love if you could follow up on a few more bootstrap 5 quirks I noticed.
It may well be that we'll decide that some of these things are "better", but we're going to be upgrading the primary site for 1.7 pretty soon and we'll loose the reference and what we have on tip will become the new formatting whether it's right or not. Awesome work on everything @thi4go ! |
My pleasure @chappjc had some trouble with my pgsql env, so took a while to test everything out. This is ready for a review mate. Will open a fresh PR for the bootstrap 5 fixes soon as well 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for this as-is. Will take this in stages and get to the data mappings discussed in #1890 (comment) in a subsequent PR
This diff updates the stimulus package to the latest version (3.0.1). It
updates data targets and uses the new API for data mapping on the
controllers and templates.
closes #1859