Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset: Make spv wallet a FeeRater and use NoLocalFeeRate for spv wallets. #2354

Closed
ukane-philemon opened this issue May 13, 2023 · 0 comments · Fixed by #2356
Closed

asset: Make spv wallet a FeeRater and use NoLocalFeeRate for spv wallets. #2354

ukane-philemon opened this issue May 13, 2023 · 0 comments · Fixed by #2356

Comments

@ukane-philemon
Copy link
Contributor

ukane-philemon commented May 13, 2023

@chappjc from matrix: I have oracles enabled and instead of going with mempool.space 's fastest fee, it uses the stupid high fee from server here's a bug somewhere. Burned over a $100 on a basic send because of this.

We need to take the approach described in the comments(See comment and NoLocalFeeRate) (for SPV wallet use it as the local estimator function, and make the spv wallet a FeeRater). The other approach would be to make btc.(*baseWallet).Send work like Redeem, using targetFeeRateWithFallback instead of feeRateWithFallback but with Send, the feeRate input is not merely a suggestion.
Basically, the external fee rates only get used for SPV (non-FeeRater) wallets in a handful of internal paths, but it's not usable to the consumer.

@ukane-philemon ukane-philemon changed the title asset: Make the spv wallet a FeeRater or use targetFeeRateWithFallback with send/withdraw asset: Make the spv wallet a FeeRater or use targetFeeRateWithFallback for send/withdraw May 13, 2023
@ukane-philemon ukane-philemon changed the title asset: Make the spv wallet a FeeRater or use targetFeeRateWithFallback for send/withdraw asset: Make the spv wallet a FeeRater or use NoLocalFeeRate for spv wallets. May 13, 2023
@ukane-philemon ukane-philemon changed the title asset: Make the spv wallet a FeeRater or use NoLocalFeeRate for spv wallets. asset: Make spv wallet a FeeRater and use NoLocalFeeRate for spv wallets. May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant