asset: Implement asset.FeeRater for SPV wallets and minor refactor
#2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
chappjc
reviewed
May 16, 2023
chappjc
approved these changes
May 18, 2023
chappjc
reviewed
May 18, 2023
| // Bitcoin Cash uses estimatefee instead of estimatesmartfee, and even | ||
| // then, they modified it from the old Bitcoin Core estimatefee by | ||
| // removing the confirmation target argument. | ||
| cloneCFG.FeeEstimator = estimateFee |
There was a problem hiding this comment.
Nice catch moving this under here. Looks like LegacyBalance: cfg.Type != walletTypeSPV, above would be best done in this case as well, but it's not wrong presently, so nbd.
Comment on lines
983
to
984
| var _ asset.FeeRater = (*ExchangeWalletFullNode)(nil) | ||
| var _ asset.FeeRater = (*ExchangeWalletNoAuth)(nil) |
There was a problem hiding this comment.
These two assertions are a bit pointless now, but they don't hurt either.
This was referenced Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2354