Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: DEX connection notifications are spammy during registration. #428

Closed
buck54321 opened this issue May 29, 2020 · 1 comment · Fixed by #710
Closed

app: DEX connection notifications are spammy during registration. #428

buck54321 opened this issue May 29, 2020 · 1 comment · Fixed by #710

Comments

@buck54321
Copy link
Member

Especially during registration, when a connection is made and closed to retrieve the registration fee.

A partial solution would be to supress the ConnectEventFunc call when the client is shutting down cleanly, but my instinct is to not use the notification tray at all, and just rely on the disconnected icon and maybe a poke notification, and only send an error notification when the connection status prevents action.

Another partial solution is to ignore those notifications during the registration process.

@JoeGruffins
Copy link
Member

I would like to add to this that any time a user shuts down the app they get the warning:
2020-06-08 12:16:27.787 [WRN] CORE: notify: |WARNING| (conn) DEX disconnected - DEX at 127.0.0.1:7232 has disconnected
which in this case is intended, so warning does not seem correct here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants