app: show multiple poke notes #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
reviewed
Oct 1, 2020
client/webserver/site/src/js/app.js
Outdated
| span.style.opacity = 1 - progress | ||
| }) | ||
| span.remove() | ||
| }, 4000) |
There was a problem hiding this comment.
I always felt the pokes should stick around a little longer if anything. TBH, I think that even more after testing.
| display: flex; | ||
| flex-direction: column; | ||
| align-items: flex-end; | ||
| border-radius: 3px 3px 0 0; |
There was a problem hiding this comment.
I feel like this might be a bit chunky:
Maybe a 4px border radius, and perhaps an extra pixel spacing between multiple poke notes?
And for future work, clicking on it could take you to the relevant order details page if it's related to an order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, only one poke-severity notification was shown at a time, and would be simply replaced if another notification came immediately after. This change makes all poke notes persist for ~4 seconds before fading away. If more than one is visible, they stack vertically.
Bonus: DEX connection and disconnection notes are now only poke-level. This resolves #428. We really don't need to persist those. If there's a problem, we'll see an error.