add price rate to browser title #1117

vctt94 · 2021-06-29T13:53:05Z

JoeGruffins

Looks good but doesn't seem to update unless I refresh the page, so if you are viewing a different page it doesn't change.

buck54321 · 2021-07-10T13:31:09Z

client/webserver/site/src/js/markets.js

+    const { book } = mktBook
+    // gets first price value from buy or from sell, so we can show it on
+    // title.
+    const firstKnownValue = book.buys[0] ? book.buys[0] : book.sells[0]


With an empty book

buck54321 · 2021-07-10T13:36:05Z

client/webserver/site/src/js/markets.js

@@ -959,6 +959,16 @@ export default class MarketsPage extends BasePage {
  handleBookRoute (note) {
    app.log('book', 'handleBookRoute:', note)
    const mktBook = note.payload
+    const { book } = mktBook


Use const book = mktBook.book for grabbing just one property.

buck54321 · 2021-07-10T13:37:43Z

client/webserver/site/src/js/markets.js

+    const { book } = mktBook
+    // gets first price value from buy or from sell, so we can show it on
+    // title.
+    const firstKnownValue = book.buys[0] ? book.buys[0] : book.sells[0]


You can update the title after the call to this.handleBook below and just use this.midGap() for the value.

buck54321 · 2021-07-10T13:39:27Z

client/webserver/site/src/js/markets.js

+      document.title = (document.title).replace(/\d+([.])?/g, '')
+      // more than 6 numbers it gets too big for the title.
+      document.title = `${firstKnownValue.rate.toFixed(6)} ${document.title}`


I'd like to see the market name. Something like 0.00512 DCR/BTC.

I don't know that we need to save the original title, which said Markets | Decred DEX, but if you do want to append the original text, grab a copy in the MarketPage constructor, this.ogTitle = document.title and just append it rather than using replace.

I removed the replace and now I am adding the selected assets into the title.

Added a new method for updating it, and now I call it on handleBookRoute, handleUnbookOrderRoute, and handleBookOrderRoute.

This way if we adding or removing new bids, it will update the title based on it.

I'd like to see the market name. Something like 0.00512 DCR/BTC.

Despite calling it the market name, is giving units to that rate, so it'll need to be BTC/DCR

Discussion in this thread: #1117 (comment)
Looks like use "DCR-BTC" and don't have units for the number.

buck54321 · 2021-07-10T13:40:08Z

client/webserver/site/src/js/markets.js

@@ -959,6 +959,16 @@ export default class MarketsPage extends BasePage {
  handleBookRoute (note) {


Doing this in handleBookRoute will set the price when the book is originally received, but will never update the value. I'm guessing we want the value to update when the book changes.

JoeGruffins

Looks pretty great to me.

chappjc · 2021-07-13T19:10:29Z

client/webserver/site/src/js/markets.js

+    const market = this.market
+    const [b, q] = [market.baseCfg, market.quoteCfg]
+    const firstSymbol = b.symbol.toUpperCase()
+    const secondSybol = q.symbol.toUpperCase()


spelling: "Sybol"
But might as well change these to baseSymb and quoteSymb while here.

chappjc · 2021-07-16T14:14:23Z

client/webserver/site/src/js/markets.js

+    const secondSybol = q.symbol.toUpperCase()
+    if (midGapValue) {
+      // more than 6 numbers it gets too big for the title.
+      document.title = `${midGapValue.toFixed(5)} ${firstSymbol}/${secondSybol}`


This is gonna say something like 0.004 DCR/BTC. The rate is inversed.

Maybe use a dash instead of a slash. When naming a market, the base symbol goes first by convention.

I will note that Bittrex bucks this trend

probably because of how confusing it is to have it written the other way.

Still, it's true that the base asset is usually first.

Somewhere in the Bittrex API docs, I remember reading an acknowledgement of this mistake. The URL and API arguments now use the standard format. Only the display is still wrong.

OK fair enough. I see the url as https://bittrex.com/Market/Index?MarketName=BTC-DCR, but I don't really strive to emulate Bittrex either way.

This PR is working well for me. However, here's what I see presently:

And here's what I'd like to see:

OR even without a dash, but it's not a big deal:

I changed it and now I am showing as your last option, without dash.

buck54321

Can clean up a tiny bit, but looks great.

client/webserver/site/src/js/markets.js

JoeGruffins reviewed Jul 2, 2021

View reviewed changes

buck54321 requested changes Jul 10, 2021

View reviewed changes

JoeGruffins approved these changes Jul 15, 2021

View reviewed changes

chappjc requested changes Jul 16, 2021

View reviewed changes

chappjc reviewed Jul 16, 2021

View reviewed changes

vctt94 added 2 commits July 16, 2021 15:49

add price rate to browser title

96b1783

update browser title on book route, add value and remove value

5a65c7e

vctt94 force-pushed the add-rate-to-title branch from 6c05405 to b1e8b12 Compare July 16, 2021 18:50

change var names and presentation

2f3f735

vctt94 force-pushed the add-rate-to-title branch from b1e8b12 to 2f3f735 Compare July 16, 2021 18:52

buck54321 approved these changes Jul 20, 2021

View reviewed changes

client/webserver/site/src/js/markets.js Show resolved Hide resolved

client/webserver/site/src/js/markets.js Outdated Show resolved Hide resolved

Add earlier return

1a34564

chappjc approved these changes Jul 23, 2021

View reviewed changes

chappjc merged commit 6231cf4 into decred:master Jul 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add price rate to browser title #1117

add price rate to browser title #1117

vctt94 commented Jun 29, 2021

JoeGruffins left a comment

buck54321 Jul 10, 2021

buck54321 Jul 10, 2021

buck54321 Jul 10, 2021

buck54321 Jul 10, 2021

vctt94 Jul 12, 2021

chappjc Jul 16, 2021

chappjc Jul 16, 2021 •

edited

Loading

buck54321 Jul 10, 2021

JoeGruffins left a comment

chappjc Jul 13, 2021

chappjc Jul 16, 2021

buck54321 Jul 16, 2021

chappjc Jul 16, 2021

buck54321 Jul 16, 2021 •

edited

Loading

chappjc Jul 16, 2021

vctt94 Jul 16, 2021

buck54321 left a comment

		@@ -959,6 +959,16 @@ export default class MarketsPage extends BasePage {
		handleBookRoute (note) {

add price rate to browser title #1117

add price rate to browser title #1117

Conversation

vctt94 commented Jun 29, 2021

JoeGruffins left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chappjc Jul 16, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoeGruffins left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

buck54321 Jul 16, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

buck54321 left a comment

Choose a reason for hiding this comment

chappjc Jul 16, 2021 •

edited

Loading

buck54321 Jul 16, 2021 •

edited

Loading