client/core: discover account via connect instead of register #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
commented
Sep 9, 2021
chappjc
force-pushed
the
discover-by-auth
branch
from
44d2087
to
4294e42
Compare
buck54321
requested changes
Sep 15, 2021
chappjc
force-pushed
the
discover-by-auth
branch
from
4294e42
to
ba65753
Compare
buck54321
approved these changes
Sep 16, 2021
JoeGruffins
approved these changes
Sep 16, 2021
chappjc
force-pushed
the
discover-by-auth
branch
from
6663f62
to
ba65753
Compare
communicate suspended status in connect result
chappjc
force-pushed
the
discover-by-auth
branch
from
ba65753
to
9280e4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for multi-asset registration fee support.
Instead of using the
'register'route to discover an existing account when restoring from an seed, use'connect'(authDEX). Initially suggested #1015 (comment)This allows account discovery without having to request a registration address. More importantly, when registration may be done with more than one asset, this avoids having to commit to a certain registration asset in order to discover an existing account. This is because the
'register'route will require an asset ID in a multi-asset registration scheme.This eliminates the "in-process"/"incomplete" registration field and simplifies some logic in
Register.